net/socket/unix_domain_listen_socket_posix_unittest.cc - Issue 382143005: Supports DevTools socket access authentication based on Android permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/unix_domain_listen_socket_posix_unittest.cc

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merged Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/dev_tools_server.cc ('K') | « net/socket/unix_domain_listen_socket_posix.cc ('k') | net/socket/unix_domain_server_socket_posix.h » ('j') | net/socket/unix_domain_server_socket_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/unix_domain_listen_socket_posix_unittest.cc

diff --git a/net/socket/unix_domain_listen_socket_posix_unittest.cc b/net/socket/unix_domain_listen_socket_posix_unittest.cc

index 5fe501730ca15ba3dff282477e0b9f68096fa1f3..3c76af1719ef6e75b9bd91a3ef4c68a150c28de3 100644

--- a/net/socket/unix_domain_listen_socket_posix_unittest.cc

+++ b/net/socket/unix_domain_listen_socket_posix_unittest.cc

@@ -138,7 +138,7 @@ class TestListenSocketDelegate : public StreamListenSocket::Delegate {

bool UserCanConnectCallback(

bool allow_user, const scoped_refptr<EventManager>& event_manager,

- uid_t, gid_t) {

+ pid_t, uid_t, gid_t) {

event_manager->Notify(

allow_user ? EVENT_AUTH_GRANTED : EVENT_AUTH_DENIED);

return allow_user;