net/socket/unix_domain_listen_socket_posix.cc - Issue 382143005: Supports DevTools socket access authentication based on Android permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/unix_domain_listen_socket_posix.cc

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merged Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/dev_tools_server.cc ('K') | « net/socket/unix_domain_client_socket_posix_unittest.cc ('k') | net/socket/unix_domain_listen_socket_posix_unittest.cc » ('j') | net/socket/unix_domain_server_socket_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/unix_domain_listen_socket_posix.cc

diff --git a/net/socket/unix_domain_listen_socket_posix.cc b/net/socket/unix_domain_listen_socket_posix.cc

index 7bab4ffcb7fe0c9df40cbfc6869969f5e61a4954..5f6a3259f56300fde5e0d459d858f6e429eb52fb 100644

--- a/net/socket/unix_domain_listen_socket_posix.cc

+++ b/net/socket/unix_domain_listen_socket_posix.cc

@@ -113,10 +113,12 @@ void UnixDomainListenSocket::Accept() {

SocketDescriptor conn = StreamListenSocket::AcceptSocket();

if (conn == kInvalidSocket)

return;

+ pid_t process_id;

uid_t user_id;

gid_t group_id;

- if (!UnixDomainServerSocket::GetPeerIds(conn, &user_id, &group_id) ||

- !auth_callback_.Run(user_id, group_id)) {

+ if (!UnixDomainServerSocket::GetPeerIds(conn,

+ &process_id, &user_id, &group_id) ||

+ !auth_callback_.Run(process_id, user_id, group_id)) {

if (IGNORE_EINTR(close(conn)) < 0)

LOG(ERROR) << "close() error";

return;