Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/extensions/extension_uninstall_dialog.h

Index: chrome/browser/extensions/extension_uninstall_dialog.h
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.h b/chrome/browser/extensions/extension_uninstall_dialog.h
index 0d2f112a1ad781feb8fb145e165efd98af28205a..f5cedbf0bdbf92fe000d355c65f140693b1f4da3 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.h
+++ b/chrome/browser/extensions/extension_uninstall_dialog.h
@@ -12,6 +12,7 @@
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/gfx/image/image_skia.h"
+#include "ui/gfx/native_widget_types.h"
 
 class Browser;
 class Profile;
@@ -43,14 +44,23 @@ class ExtensionUninstallDialog
     virtual ~Delegate() {}
   };
 
-  // Creates a platform specific implementation of ExtensionUninstallDialog.
-  // |profile| and |delegate| can never be NULL.
-  // |browser| can be NULL only for Ash when this is used with the applist
-  // window.
+  // Creates a platform-specific implementation of ExtensionUninstallDialog for
+  // the given browser window.
   static ExtensionUninstallDialog* Create(Profile* profile,
                                           Browser* browser,
                                           Delegate* delegate);
 
+  // Create a platform-specific implementation of ExtensionUninstallDialog for
+  // the app list (or a child widget in the app list).

[msw, 2014/07/14 17:38:31]

nit: explain high-level how/why the dialog is different in this case.

[not at google - send to devlin, 2014/07/15 16:31:04]

is it possible to refactor ::Create to take a gfx::NativeWindow and not need
this at all? what's the Browser needed for there?

+  static ExtensionUninstallDialog* CreateForAppList(Profile* profile,
+                                                    gfx::NativeWindow parent,
+                                                    Delegate* delegate);
+
+  // Create a platform-specific implementation of ExtensionUninstallDialog with
+  // no parent widget (behaves like a standalone window).
+  static ExtensionUninstallDialog* CreateAsStandaloneDialog(Profile* profile,

[msw, 2014/07/14 17:38:31]

Can't users just call Create(profile, NULL, delegate)?

[not at google - send to devlin, 2014/07/15 16:31:04]

TBH if a parameter is nullable I prefer providing an overloaded method without
that parameter.

what does it mean for a dialogue to "not have a parent window"? that it's not
modal? anyway, I think Create() is a better name.

+                                                            Delegate* delegate);
+
   virtual ~ExtensionUninstallDialog();
 
   // This is called to verify whether the uninstallation should proceed.