chrome/browser/extensions/extension_storage_monitor.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_storage_monitor.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_storage_monitor.cc

diff --git a/chrome/browser/extensions/extension_storage_monitor.cc b/chrome/browser/extensions/extension_storage_monitor.cc

index b03ed58d4bf94f9cfafaff30d76b68b84f82cf8a..2a958345e790721da45be24fb45413f59565cb03 100644

--- a/chrome/browser/extensions/extension_storage_monitor.cc

+++ b/chrome/browser/extensions/extension_storage_monitor.cc

@@ -547,8 +547,8 @@ void ExtensionStorageMonitor::ShowUninstallPrompt(

return;

if (!uninstall_dialog_.get()) {

- uninstall_dialog_.reset(ExtensionUninstallDialog::Create(

- Profile::FromBrowserContext(context_), NULL, this));

+ uninstall_dialog_.reset(ExtensionUninstallDialog::CreateAsStandaloneDialog(

+ Profile::FromBrowserContext(context_), this));

}

uninstall_extension_id_ = extension->id();

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_uninstall_dialog.h » ('j') | chrome/browser/extensions/extension_uninstall_dialog.h » ('J')