chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback & todos for unfixed issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/extension_uninstaller.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

index 548b2a0bc0d0439cde139b9436f470f467be5d85..de9c63b7043a1e399854c726611b9142be6f1a59 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

@@ -12,6 +12,7 @@

#include "chrome/browser/extensions/extension_uninstall_dialog.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"

#include "chrome/browser/ui/cocoa/browser_window_controller.h"

@@ -45,7 +46,8 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {

: extension_(extension),

profile_(browser->profile()) {

extension_uninstall_dialog_.reset(

- extensions::ExtensionUninstallDialog::Create(profile_, browser, this));

+ extensions::ExtensionUninstallDialog::Create(

+ profile_, browser->window()->GetNativeWindow(), this));

extension_uninstall_dialog_->ConfirmUninstall(extension_);

}