chrome/browser/ui/app_list/extension_uninstaller.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_uninstaller.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback & todos for unfixed issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_uninstall_dialog.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/extension_uninstaller.cc

diff --git a/chrome/browser/ui/app_list/extension_uninstaller.cc b/chrome/browser/ui/app_list/extension_uninstaller.cc

index 138b7ae72aac7885580cefccefcdd73ba5db2826..10006d1fd51410c809f09f1f63ab76622928922c 100644

--- a/chrome/browser/ui/app_list/extension_uninstaller.cc

+++ b/chrome/browser/ui/app_list/extension_uninstaller.cc

@@ -32,8 +32,8 @@ void ExtensionUninstaller::Run() {

return;

}

controller_->OnShowChildDialog();

- dialog_.reset(

- extensions::ExtensionUninstallDialog::Create(profile_, NULL, this));

+ dialog_.reset(extensions::ExtensionUninstallDialog::Create(

+ profile_, controller_->GetAppListWindow(), this));

dialog_->ConfirmUninstall(extension);

}