chrome/browser/extensions/extension_disabled_ui.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback & todos for unfixed issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/extension_uninstall_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc

index ea131d5deaf551e24dc229dbf7f0deedb1a59fca..b2a9a9c8a1228ec40be7127e2bda8db4861b5c92 100644

--- a/chrome/browser/extensions/extension_disabled_ui.cc

+++ b/chrome/browser/extensions/extension_disabled_ui.cc

@@ -23,6 +23,7 @@

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/global_error/global_error.h"

#include "chrome/browser/ui/global_error/global_error_service.h"

#include "chrome/browser/ui/global_error/global_error_service_factory.h"

@@ -347,7 +348,7 @@ void ExtensionDisabledGlobalError::BubbleViewCancelButtonPressed(

Browser* browser) {

#if !defined(OS_ANDROID)

uninstall_dialog_.reset(extensions::ExtensionUninstallDialog::Create(

- service_->profile(), browser, this));

+ service_->profile(), browser->window()->GetNativeWindow(), this));

// Delay showing the uninstall dialog, so that this function returns

// immediately, to close the bubble properly. See crbug.com/121544.

base::MessageLoop::current()->PostTask(