chrome/browser/extensions/extension_context_menu_model.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback & todos for unfixed issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api.cc ('k') | chrome/browser/extensions/extension_disabled_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_context_menu_model.cc

diff --git a/chrome/browser/extensions/extension_context_menu_model.cc b/chrome/browser/extensions/extension_context_menu_model.cc

index 1890a0ec9e1186626eb5f0a234c74e6e470328a2..8ddb94b94651320226fd31e3659051ebb1c00d82 100644

--- a/chrome/browser/extensions/extension_context_menu_model.cc

+++ b/chrome/browser/extensions/extension_context_menu_model.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/extensions/extension_constants.h"

@@ -125,7 +126,7 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id,

AddRef(); // Balanced in Accepted() and Canceled()

extension_uninstall_dialog_.reset(

extensions::ExtensionUninstallDialog::Create(

- profile_, browser_, this));

+ profile_, browser_->window()->GetNativeWindow(), this));

extension_uninstall_dialog_->ConfirmUninstall(extension);

break;

}

« no previous file with comments | « chrome/browser/extensions/api/management/management_api.cc ('k') | chrome/browser/extensions/extension_disabled_ui.cc » ('j') | no next file with comments »