Fix the black patch which would appear at the top of app windows in Chrome desktop windows with HiD…

Fix the black patch which would appear at the top of app windows in Chrome desktop windows with HiDPI

The bug occurs because the non client insets which account for the window frame are retrieved via the
GetSystemMetrics API which returns values in pixels.

Changes as below:-
1. Renamed the GlassAppWindowFrameViewWin::GetGlassInsets function to GetGlassInsetsInDIP.
2. Replaced calls to the GetSystemMetrics API in the GetGlassInsetsInDIP function with the dpi helper
   GetSystemMetricsInDIP.
3. Added code to convert the insets to pixels in the AppWindowDesktopWindowTreeHostWin::UpdateDWMFrame
   function.

BUG=392603
TBR=benwells

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282682

[sky, 2014-07-10 23:11:09]

https://codereview.chromium.org/382013004/diff/1/chrome/browser/ui/views/apps...
File chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h (right):

https://codereview.chromium.org/382013004/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h:24: gfx::Insets
GetGlassInsetsInDIP() const;
I don't think you need to rename this. Everything should be in DIPs unless
otherwise said.

[ananta, 2014-07-10 23:20:58]

https://codereview.chromium.org/382013004/diff/1/chrome/browser/ui/views/apps...
File chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h (right):

https://codereview.chromium.org/382013004/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h:24: gfx::Insets
GetGlassInsetsInDIP() const;
On 2014/07/10 23:11:09, sky wrote:
> I don't think you need to rename this. Everything should be in DIPs unless
> otherwise said.

Done.

[sky, 2014-07-11 15:26:13]

LGTM

https://codereview.chromium.org/382013004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
(right):

https://codereview.chromium.org/382013004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc:75:
gfx::Insets insets_in_dip =
nit: insets is fine here. Since most things are in dips we generally only add
pixels. So, if you want to change something make insets_rect
insets_rect_in_pixels.

[ananta, 2014-07-11 18:13:47]

TBR'ing benwells

https://codereview.chromium.org/382013004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
(right):

https://codereview.chromium.org/382013004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc:75:
gfx::Insets insets_in_dip =
On 2014/07/11 15:26:13, sky wrote:
> nit: insets is fine here. Since most things are in dips we generally only add
> pixels. So, if you want to change something make insets_rect
> insets_rect_in_pixels.

Done.

[ananta, 2014-07-11 18:14:16]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-07-11 18:15:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/382013004/40001

[commit-bot: I haz the power, 2014-07-11 20:22:59]

Change committed as 282682