Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3446)

Unified Diff: chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc

Issue 382013004: Fix the black patch which would appear at the top of app windows in Chrome desktop windows with HiD… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
diff --git a/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc b/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
index b2301e69bcfb06ec07e0dd16cf907c8173bb12e1..be9a207739527d43786b82e5496f2942be979e01 100644
--- a/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
+++ b/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
@@ -73,10 +73,19 @@ void AppWindowDesktopWindowTreeHostWin::UpdateDWMFrame() {
// Otherwise, we need to figure out how to extend the glass in.
if (app_window_->glass_frame_view()) {
gfx::Insets insets = app_window_->glass_frame_view()->GetGlassInsets();
- margins.cxLeftWidth = insets.left();
- margins.cxRightWidth = insets.right();
- margins.cyBottomHeight = insets.bottom();
- margins.cyTopHeight = insets.top();
+ // The DWM API's expect values in pixels. We need to convert from DIP to
+ // pixels here.
+ gfx::Rect insets_rect_in_pixels(insets.left(),
+ insets.top(),
+ insets.right() - insets.left(),
+ insets.bottom() - insets.top());
+ insets_rect_in_pixels = gfx::win::DIPToScreenRect(insets_rect_in_pixels);
+ margins.cxLeftWidth = insets_rect_in_pixels.x();
+ margins.cxRightWidth =
+ insets_rect_in_pixels.x() + insets_rect_in_pixels.width();
+ margins.cyBottomHeight =
+ insets_rect_in_pixels.y() + insets_rect_in_pixels.height();
+ margins.cyTopHeight = insets_rect_in_pixels.y();
}
DwmExtendFrameIntoClientArea(GetHWND(), &margins);
« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698