Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 382003004: Revert 282393 "Do not call glDrawBuffersARB when the extension i..." (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282393 "Do not call glDrawBuffersARB when the extension i..." Broke gpu_unittests FramebufferInfoTest.DrawBuffers: [ RUN ] FramebufferInfoTest.DrawBuffers ../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:653: Failure Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))... Expected: to be called once Actual: never called - unsatisfied and active ../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:657: Failure Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))... Expected: to be called once Actual: never called - unsatisfied and active [ FAILED ] FramebufferInfoTest.DrawBuffers (1 ms) > Do not call glDrawBuffersARB when the extension is absent > > The function Framebuffer::ChangeDrawBuffersHelper was assuming > that binding of an FBO with no GL_COLOR_ATTACHMENT0 was > accompanied by setting the first draw buffer to GL_NONE with > glDrawBuffersARB in the fix introduced in: > https://codereview.chromium.org/315283002 > > When the extension is not present, it can be assumed that the > glDrawBuffersARB state need not be set and restored. > > BUG=(wrangling) > NOTRY=True > > Review URL: https://codereview.chromium.org/375413003 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M trunk/src/gpu/command_buffer/service/framebuffer_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
6 years, 5 months ago (2014-07-10 19:50:38 UTC) #1
scherkus (not reviewing)
6 years, 5 months ago (2014-07-10 19:50:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r282402 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698