Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 381923002: [Android]: Don't omit the frame pointer on Arm64. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Android]: Don't omit the frame pointer on Arm64. If we omit the frame pointer on Arm64 there is no way for breakpad to correctly symbolize stack traces which contain stack frames for which we don't have CFI information (e.g., system libraries like libc.so). This is because the Arm64 ABI does not specify where a frame pointer should be in a stack frame, so, without CFI information, there is no way to calculate the start of the caller's frame if the caller omits the frame pointer. More details are on the bug. BUG=391706 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M build/common.gypi View 3 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmcilroy
Primiano, could you please take a look, thanks.
6 years, 5 months ago (2014-07-10 13:58:43 UTC) #1
Primiano Tucci (use gerrit)
LGTM. Just please fix the CL description. I think the first line should be <= ...
6 years, 5 months ago (2014-07-10 14:44:20 UTC) #2
rmcilroy
On 2014/07/10 14:44:20, Primiano Tucci wrote: > LGTM. > Just please fix the CL description. ...
6 years, 5 months ago (2014-07-10 15:37:36 UTC) #3
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 5 months ago (2014-07-10 15:37:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/381923002/1
6 years, 5 months ago (2014-07-10 15:39:14 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 17:37:42 UTC) #6
Message was sent while issue was closed.
Change committed as 282370

Powered by Google App Engine
This is Rietveld 408576698