Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Side by Side Diff: build/common.gypi

Issue 381923002: [Android]: Don't omit the frame pointer on Arm64. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3417 matching lines...) Expand 10 before | Expand all | Expand 10 after
3428 '-Wl,--warn-shared-textrel', 3428 '-Wl,--warn-shared-textrel',
3429 ], 3429 ],
3430 }], 3430 }],
3431 ['OS=="android" and android_full_debug==0', { 3431 ['OS=="android" and android_full_debug==0', {
3432 # Some configurations are copied from Release_Base to reduce 3432 # Some configurations are copied from Release_Base to reduce
3433 # the binary size. 3433 # the binary size.
3434 'variables': { 3434 'variables': {
3435 'debug_optimize%': 's', 3435 'debug_optimize%': 's',
3436 }, 3436 },
3437 'cflags': [ 3437 'cflags': [
3438 '-fomit-frame-pointer',
3439 '-fdata-sections', 3438 '-fdata-sections',
3440 '-ffunction-sections', 3439 '-ffunction-sections',
3441 ], 3440 ],
3442 'ldflags': [ 3441 'ldflags': [
3443 '-Wl,-O1', 3442 '-Wl,-O1',
3444 '-Wl,--as-needed', 3443 '-Wl,--as-needed',
3445 ], 3444 ],
3446 }], 3445 }],
3446 ['OS=="android" and android_full_debug==0 and target_arch!="arm64" ', {
3447 # We don't omit frame pointers on arm64 since they are required
3448 # to correctly unwind stackframes which contain system library
3449 # function frames (crbug.com/391706).
3450 'cflags': [
3451 '-fomit-frame-pointer',
3452 ],
3453 }],
3447 ['OS=="linux" and target_arch=="ia32"', { 3454 ['OS=="linux" and target_arch=="ia32"', {
3448 'ldflags': [ 3455 'ldflags': [
3449 '-Wl,--no-as-needed', 3456 '-Wl,--no-as-needed',
3450 ], 3457 ],
3451 }], 3458 }],
3452 ['debug_unwind_tables==1', { 3459 ['debug_unwind_tables==1', {
3453 'cflags': ['-funwind-tables'], 3460 'cflags': ['-funwind-tables'],
3454 }, { 3461 }, {
3455 'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-table s'], 3462 'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-table s'],
3456 }], 3463 }],
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
3492 # See http://lwn.net/Articles/192624/ . 3499 # See http://lwn.net/Articles/192624/ .
3493 '-Wl,-O1', 3500 '-Wl,-O1',
3494 '-Wl,--as-needed', 3501 '-Wl,--as-needed',
3495 ], 3502 ],
3496 'conditions' : [ 3503 'conditions' : [
3497 ['no_gc_sections==0', { 3504 ['no_gc_sections==0', {
3498 'ldflags': [ 3505 'ldflags': [
3499 '-Wl,--gc-sections', 3506 '-Wl,--gc-sections',
3500 ], 3507 ],
3501 }], 3508 }],
3509 ['OS=="android" and target_arch!="arm64"', {
3510 # We don't omit frame pointers on arm64 since they are required
3511 # to correctly unwind stackframes which contain system library
3512 # function frames (crbug.com/391706).
3513 'cflags': [
3514 '-fomit-frame-pointer',
3515 ]
3516 }],
3502 ['OS=="android"', { 3517 ['OS=="android"', {
3503 'variables': { 3518 'variables': {
3504 'release_optimize%': 's', 3519 'release_optimize%': 's',
3505 }, 3520 },
3506 'cflags': [
3507 '-fomit-frame-pointer',
3508 ],
3509 'ldflags': [ 3521 'ldflags': [
3510 # Warn in case of text relocations. 3522 # Warn in case of text relocations.
3511 '-Wl,--warn-shared-textrel', 3523 '-Wl,--warn-shared-textrel',
3512 ], 3524 ],
3513 }], 3525 }],
3514 ['clang==1', { 3526 ['clang==1', {
3515 'cflags!': [ 3527 'cflags!': [
3516 '-fno-ident', 3528 '-fno-ident',
3517 ], 3529 ],
3518 }], 3530 }],
(...skipping 2081 matching lines...) Expand 10 before | Expand all | Expand 10 after
5600 # settings in target dicts. SYMROOT is a special case, because many other 5612 # settings in target dicts. SYMROOT is a special case, because many other
5601 # Xcode variables depend on it, including variables such as 5613 # Xcode variables depend on it, including variables such as
5602 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5614 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5603 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5615 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5604 # files to appear (when present) in the UI as actual files and not red 5616 # files to appear (when present) in the UI as actual files and not red
5605 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5617 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5606 # and therefore SYMROOT, needs to be set at the project level. 5618 # and therefore SYMROOT, needs to be set at the project level.
5607 'SYMROOT': '<(DEPTH)/xcodebuild', 5619 'SYMROOT': '<(DEPTH)/xcodebuild',
5608 }, 5620 },
5609 } 5621 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698