Issue 381913002: Revert 281809 "Password bubble: Don't focus by default."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 381913002: Revert 281809 "Password bubble: Don't focus by default." (Closed)

Created:
6 years, 5 months ago by vasilii

Modified:
6 years, 5 months ago

Reviewers:
Mike West

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 281809 "Password bubble: Don't focus by default." The patch made the bubble unresponsive on Win (see crbug/392734). > Password bubble: Don't focus by default. > > BUG=383821 > > Review URL: https://codereview.chromium.org/373043003 TBR=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282325

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -14 lines)			Patch
M	trunk/src/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

vasilii

Committed patchset #1 manually as r282325 (tree was closed).

6 years, 5 months ago (2014-07-10 13:50:59 UTC) #2

Mike West

6 years, 5 months ago (2014-07-10 13:51:56 UTC) #3

Message was sent while issue was closed.

On 2014/07/10 at 13:50:59, vasilii wrote:
> Committed patchset #1 manually as r282325 (tree was closed).

LGTM, thanks.