Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 381753002: Revert of [screen-orientation] Update implementation to match recent spec changes. (Closed)

Created:
6 years, 5 months ago by Justin Novosad
Modified:
6 years, 5 months ago
CC:
blink-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [screen-orientation] Update implementation to match recent spec changes. (https://codereview.chromium.org/374623002/) Reason for revert: Causing content_browsertests failure on Android: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20086/steps/content_browsertests Original issue's description: > [screen-orientation] Update implementation to match recent spec changes. > > https://github.com/w3c/screen-orientation/pull/21 > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177734 TBR=abarth@chromium.org,ager@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -510 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/screen_orientation/lockOrientation-bad-argument.html View 1 chunk +28 lines, -56 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/screen_orientation/lockOrientation-basic.html View 2 chunks +7 lines, -7 lines 0 comments Download
A LayoutTests/screen_orientation/orientation-attribute.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/orientation-attribute-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
D LayoutTests/screen_orientation/orientation-reading.html View 1 chunk +0 lines, -50 lines 0 comments Download
M LayoutTests/screen_orientation/orientationchange-event.html View 2 chunks +16 lines, -9 lines 0 comments Download
M LayoutTests/screen_orientation/orientationchange-event-subframe.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/screen_orientation/page-visibility.html View 4 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/screen_orientation/resources/iframe-listen-orientation-change.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/screen_orientation/resources/sandboxed-iframe-locking.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/screen_orientation/screenorientation-api.html View 1 chunk +7 lines, -27 lines 0 comments Download
A LayoutTests/screen_orientation/screenorientation-api-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/modules/EventTargetModulesFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 3 chunks +1 line, -4 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 1 chunk +14 lines, -32 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 3 chunks +41 lines, -70 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.idl View 2 chunks +15 lines, -18 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 3 chunks +6 lines, -17 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 6 chunks +34 lines, -76 lines 0 comments Download
D Source/modules/screen_orientation/ScreenScreenOrientation.h View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/modules/screen_orientation/ScreenScreenOrientation.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/modules/screen_orientation/ScreenScreenOrientation.idl View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Justin Novosad
Created Revert of [screen-orientation] Update implementation to match recent spec changes.
6 years, 5 months ago (2014-07-09 18:51:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/381753002/1
6 years, 5 months ago (2014-07-09 18:51:37 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 18:52:43 UTC) #3
Message was sent while issue was closed. 
Change committed as 177763

Powered by Google App Engine
This is Rietveld 408576698