Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

Issue 381753002: Revert of [screen-orientation] Update implementation to match recent spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html
diff --git a/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html b/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html
new file mode 100644
index 0000000000000000000000000000000000000000..0c56955351bd8573e893ea6d48268be7ff778c7e
--- /dev/null
+++ b/LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src="../resources/js-test.js"></script>
+<script>
+description("Validates that lockOrientation() returns false on bad orientation value in array argument.");
+window.jsTestIsAsync = true;
+
+function onOrientationChangeEvent(ev) {
+ testFailed("Unexpected 'orientationchange' event");
+}
+
+function completeTest() {
+ shouldBeEqualToString("screen.orientation", "portrait-primary");
+ screen.unlockOrientation();
+ finishJSTest();
+}
+
+window.addEventListener("orientationchange", onOrientationChangeEvent);
+
+function typeErrorEnum(argStr) {
+ return "TypeError: Failed to execute 'lockOrientation' on 'Screen': parameter 1 ('" + argStr + "') is not a valid enum value.";
+}
+
+shouldBeEqualToString("screen.orientation", "portrait-primary");
+// Bad argument to lockOrientation(), we should not get locked.
+shouldThrow("screen.lockOrientation(['portrait-primary', 'invalid-orientation'])", "typeErrorEnum('portrait-primary,invalid-orientation')");
+shouldThrow("screen.lockOrientation(['portrait-primary', null])", "typeErrorEnum('portrait-primary,')");
+shouldThrow("screen.lockOrientation(['portrait-primary', undefined])", "typeErrorEnum('portrait-primary,')");
+shouldThrow("screen.lockOrientation(['portrait-primary', 123])", "typeErrorEnum('portrait-primary,123')");
+shouldThrow("screen.lockOrientation(['portrait-primary', window])", "typeErrorEnum('portrait-primary,[object Window]')");
+
+// Finish asynchronously to give events a chance to fire.
+setTimeout(completeTest, 0);
+</script>
+</body>
+</html>
+

Powered by Google App Engine
This is Rietveld 408576698