tools/telemetry/telemetry/value/string_unittest.py - Issue 381723002: Refactor Telemetry value system to support AsDict()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/string_unittest.py

Issue 381723002: Refactor Telemetry value system to support AsDict() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's Comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/string_unittest.py

diff --git a/tools/telemetry/telemetry/value/string_unittest.py b/tools/telemetry/telemetry/value/string_unittest.py

index cc0e2141a3a04f5f87f0bb8f6df8e4f297e1c290..5728b4f8b03ff79643b4f4bcb5ee7f3b3312e35a 100644

--- a/tools/telemetry/telemetry/value/string_unittest.py

+++ b/tools/telemetry/telemetry/value/string_unittest.py

@@ -59,3 +59,11 @@ class StringValueTest(TestBase):

self.assertEquals('label', vM.units)

self.assertEquals(True, vM.important)

self.assertEquals(['L1', 'L2'], vM.values)

+ def testAsDictIsAccurate(self):

+ v = string.StringValue(None, 'x', 'unit', 'foo', important=False)

+ d = v.AsDictWithoutBaseClassEntries()

+ self.assertEquals(d, {

+ 'value': 'foo'

+ })