Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: tools/telemetry/telemetry/value/string.py

Issue 381723002: Refactor Telemetry value system to support AsDict() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's Comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/string.py
diff --git a/tools/telemetry/telemetry/value/string.py b/tools/telemetry/telemetry/value/string.py
index f413f8b8e95eb8a56bef9c0976339bcd5ece2bd8..9ca47f5a969e8dc533e989dc446a7b24cf0c4c42 100644
--- a/tools/telemetry/telemetry/value/string.py
+++ b/tools/telemetry/telemetry/value/string.py
@@ -45,6 +45,15 @@ class StringValue(value_module.Value):
return str(self.value)
@classmethod
+ def GetJSONTypeName(cls):
+ return 'string'
+
+ def AsDict(self):
+ d = super(StringValue, self).AsDict()
+ d['value'] = self.value
+ return d
+
+ @classmethod
def MergeLikeValuesFromSamePage(cls, values):
assert len(values) > 0
v0 = values[0]
« no previous file with comments | « tools/telemetry/telemetry/value/scalar_unittest.py ('k') | tools/telemetry/telemetry/value/string_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698