Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: tools/telemetry/telemetry/value/list_of_string_values_unittest.py

Issue 381723002: Refactor Telemetry value system to support AsDict() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's Comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_string_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/list_of_string_values_unittest.py
diff --git a/tools/telemetry/telemetry/value/list_of_string_values_unittest.py b/tools/telemetry/telemetry/value/list_of_string_values_unittest.py
index a2dacc1059e0da54d80efb77ffe3906c84b79d6e..42d26f0d70d8d391adfc1ae681d46df7f1864a84 100644
--- a/tools/telemetry/telemetry/value/list_of_string_values_unittest.py
+++ b/tools/telemetry/telemetry/value/list_of_string_values_unittest.py
@@ -76,3 +76,13 @@ class ListOfStringValuesTest(TestBase):
self.assertEquals(value.PICK_FIRST, vM.same_page_merge_policy)
self.assertEquals(True, vM.important)
self.assertEquals(['L1', 'L2', 'L3', 'L4'], vM.values)
+
+ def testAsDictIsAccurate(self):
+ v = list_of_string_values.ListOfStringValues(
+ None, 'x', 'unit', ['foo', 'bar'],
+ same_page_merge_policy=value.PICK_FIRST, important=False)
+ d = v.AsDictWithoutBaseClassEntries()
+
+ self.assertEquals(d, {
+ 'values': ['foo', 'bar']
+ })
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_string_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698