Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: tools/telemetry/telemetry/value/list_of_string_values.py

Issue 381723002: Refactor Telemetry value system to support AsDict() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's Comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/list_of_string_values.py
diff --git a/tools/telemetry/telemetry/value/list_of_string_values.py b/tools/telemetry/telemetry/value/list_of_string_values.py
index 02900e3640a129dc41ba6f1e66b78f7b3a970351..f029279a316dc085b25e628a1c068ee5eaa4d86f 100644
--- a/tools/telemetry/telemetry/value/list_of_string_values.py
+++ b/tools/telemetry/telemetry/value/list_of_string_values.py
@@ -51,6 +51,15 @@ class ListOfStringValues(value_module.Value):
self.same_page_merge_policy == that.same_page_merge_policy)
@classmethod
+ def GetJSONTypeName(cls):
+ return 'list_of_string_values'
+
+ def AsDict(self):
+ d = super(ListOfStringValues, self).AsDict()
+ d['values'] = self.values
+ return d
+
+ @classmethod
def MergeLikeValuesFromSamePage(cls, values):
assert len(values) > 0
v0 = values[0]

Powered by Google App Engine
This is Rietveld 408576698