Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: components/autofill/core/browser/credit_card_field.h

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/credit_card_field.h
diff --git a/components/autofill/core/browser/credit_card_field.h b/components/autofill/core/browser/credit_card_field.h
index bf45e7ee6efb0194481158448104546b07e9ff85..ce2843bc624635650f563f535042392b1f5c1701 100644
--- a/components/autofill/core/browser/credit_card_field.h
+++ b/components/autofill/core/browser/credit_card_field.h
@@ -20,6 +20,7 @@ class AutofillScanner;
class CreditCardField : public FormField {
public:
+ virtual ~CreditCardField();
static FormField* Parse(AutofillScanner* scanner);
protected:
@@ -44,7 +45,7 @@ class CreditCardField : public FormField {
// TODO(jhawkins): Parse the select control.
const AutofillField* type_; // Optional.
- const AutofillField* number_; // Required.
+ std::vector<const AutofillField*> numbers_; // Required.
// The 3-digit card verification number; we don't currently fill this.
const AutofillField* verification_;

Powered by Google App Engine
This is Rietveld 408576698