components/autofill/core/browser/autofill_regex_constants.cc.utf8 - Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_regex_constants.cc.utf8

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_field.cc ('K') | « components/autofill/core/browser/autofill_field_unittest.cc ('k') | components/autofill/core/browser/credit_card_field.h » ('j') | components/autofill/core/browser/credit_card_field.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_regex_constants.cc.utf8

diff --git a/components/autofill/core/browser/autofill_regex_constants.cc.utf8 b/components/autofill/core/browser/autofill_regex_constants.cc.utf8

index d0378dffab7f7d6d3979a1c74f7ecc4a1b2b9e86..513c1c0f1ea67884f7a2de391c6a0e8ccf136e88 100644

--- a/components/autofill/core/browser/autofill_regex_constants.cc.utf8

+++ b/components/autofill/core/browser/autofill_regex_constants.cc.utf8

@@ -131,7 +131,7 @@ const char kNameOnCardRe[] =

const char kNameOnCardContextualRe[] =

"name";

const char kCardNumberRe[] =

- "card.?number|card.?#|card.?no|cc.?num|acct.?num"

+ "card.?number.?\\d*|card.?#|card.?no.?\\d*|acct.?num.?\\d*|\\w*part.?\\d{1}|\\w*q.?\\d{1}|cc.?num.?\\d*"

Ilya Sherman 2014/08/07 20:57:25 Why did you add ".?\\d*" to these regexes? It sho

Pritam Nikam 2014/08/08 14:14:34 Done. Restored the original regular expression.

"|nummer" // de-DE

"|credito|numero|número" // es

"|numéro" // fr-FR