Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 381473002: Use reference for FillLayer if possible (Closed)

Created:
6 years, 5 months ago by Xianzhu
Modified:
6 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-rendering, dglazkov+blink, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr., rjwright, rwlbuis, rune+blink, shans, Steve Block, Timothy Loh, zoltan1
Project:
blink
Visibility:
Public.

Description

Use reference for FillLayer if possible RenderStyle::backgroundBackgroundLayers() and maskLayers() always return non-null FillLayer, so we can reference for them. Also changed accessBackgroundLayers() and accessMaskLayers(). Also changed callers and some callers of callers of the functions. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178071

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -187 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 6 chunks +52 lines, -57 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 10 chunks +18 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 19 chunks +37 lines, -37 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/CachedUAStyle.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
6 years, 5 months ago (2014-07-09 01:01:26 UTC) #1
Xianzhu
6 years, 5 months ago (2014-07-10 18:12:42 UTC) #2
esprehn
lgtm, seems reasonable.
6 years, 5 months ago (2014-07-14 08:31:32 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 5 months ago (2014-07-14 16:10:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/381473002/20001
6 years, 5 months ago (2014-07-14 16:10:55 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 16:14:06 UTC) #6
Message was sent while issue was closed.
Change committed as 178071

Powered by Google App Engine
This is Rietveld 408576698