Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: Source/core/rendering/RenderTheme.cpp

Issue 381473002: Use reference for FillLayer if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 { 550 {
551 // There are more leaves than this, but we'll patch this function as we add support for 551 // There are more leaves than this, but we'll patch this function as we add support for
552 // more controls. 552 // more controls.
553 return appearance != CheckboxPart && appearance != RadioPart; 553 return appearance != CheckboxPart && appearance != RadioPart;
554 } 554 }
555 555
556 static bool isBackgroundOrBorderStyled(const RenderStyle& style, const CachedUAS tyle& uaStyle) 556 static bool isBackgroundOrBorderStyled(const RenderStyle& style, const CachedUAS tyle& uaStyle)
557 { 557 {
558 // Code below excludes the background-repeat from comparison by resetting it 558 // Code below excludes the background-repeat from comparison by resetting it
559 FillLayer backgroundCopy = uaStyle.backgroundLayers; 559 FillLayer backgroundCopy = uaStyle.backgroundLayers;
560 FillLayer backgroundLayersCopy = *style.backgroundLayers(); 560 FillLayer backgroundLayersCopy = style.backgroundLayers();
561 backgroundCopy.setRepeatX(NoRepeatFill); 561 backgroundCopy.setRepeatX(NoRepeatFill);
562 backgroundCopy.setRepeatY(NoRepeatFill); 562 backgroundCopy.setRepeatY(NoRepeatFill);
563 backgroundLayersCopy.setRepeatX(NoRepeatFill); 563 backgroundLayersCopy.setRepeatX(NoRepeatFill);
564 backgroundLayersCopy.setRepeatY(NoRepeatFill); 564 backgroundLayersCopy.setRepeatY(NoRepeatFill);
565 // Test the style to see if the UA border and background match. 565 // Test the style to see if the UA border and background match.
566 return style.border() != uaStyle.border 566 return style.border() != uaStyle.border
567 || backgroundLayersCopy != backgroundCopy 567 || backgroundLayersCopy != backgroundCopy
568 || style.visitedDependentColor(CSSPropertyBackgroundColor) != uaStyle.ba ckgroundColor; 568 || style.visitedDependentColor(CSSPropertyBackgroundColor) != uaStyle.ba ckgroundColor;
569 } 569 }
570 570
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
1218 1218
1219 // padding - not honored by WinIE, needs to be removed. 1219 // padding - not honored by WinIE, needs to be removed.
1220 style->resetPadding(); 1220 style->resetPadding();
1221 1221
1222 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 1222 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
1223 // for now, we will not honor it. 1223 // for now, we will not honor it.
1224 style->resetBorder(); 1224 style->resetBorder();
1225 } 1225 }
1226 1226
1227 } // namespace WebCore 1227 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698