Issue 381273003: [GCM] Close the socket on connection factory shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 381273003: [GCM] Close the socket on connection factory shutdown (Closed)

Created:
6 years, 5 months ago by Nicolas Zea

Modified:
6 years, 5 months ago

Reviewers:
fgorski

CC:
chromium-reviews, zea+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[GCM] Close the socket on connection factory shutdown We don't want to attempt to reuse a socket across shutdowns, and given socket pools any open socket can be reused. Make sure to close the socket on shutdown BUG=392546 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282551