google_apis/gcm/engine/connection_factory_impl.cc - Issue 381273003: [GCM] Close the socket on connection factory shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl.cc

Issue 381273003: [GCM] Close the socket on connection factory shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/connection_factory_impl.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc

index bc5a745ea6399e20781f3467f3a19a7ea5e98fa2..a1d279446f0efaecce753123d4b811ec5f3406b2 100644

--- a/google_apis/gcm/engine/connection_factory_impl.cc

+++ b/google_apis/gcm/engine/connection_factory_impl.cc

@@ -66,6 +66,7 @@ ConnectionFactoryImpl::ConnectionFactoryImpl(

}

ConnectionFactoryImpl::~ConnectionFactoryImpl() {

+ CloseSocket();

net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);

if (pac_request_) {

network_session_->proxy_service()->CancelPacRequest(pac_request_);

« no previous file with comments | « no previous file | no next file » | no next file with comments »