MacViews: Initial chrome_browser_ui.gypi support for views on mac

MacViews: Initial chrome_browser_ui.gypi support for views on mac

Allows target `chrome` to compile on Mac with toolkit-views. (It also
runs!)

This CL effectively renames the `chrome_browser_ui_views_sources`
sources list to `chrome_browser_ui_views_non_mac_sources`.
chrome_browser_ui_views_sources is now just the subset of files which
are ready for toolkit views on mac.

A use_aura condition becomes toolkit_views to control the filtering of
browser/ui/views/. This also enables other, ready views files for
compilation on a mac toolkit-views build: That is, those not currently
listed in chrome_browser_ui_views_sources, but with a browser/ui/views
prefix (e.g. browser/ui/views/app_list/). This would also include
task_manager_view.cc, which isn't ready, so it's dealt with separately.

For sizes, the linker is still able to do a good job pruning. A local
official/release build for `Google Chrome Framework` suggests this will
regress sizes just a small amount. Additionally enabling the views task
manager (patchset 8) ensures a sufficiently interesting portion of
views.a is linked as well, which regresses sizes more. Results:

Before: framework 78368kB, resources 45040kB
After: framework 78480kB, resources 45232kB (0.14%, 0.42%)
Later (with views+cocoa taskmanagers): 78796kB, resources 45244kB
(0.54%, 0.45% vs "before")

Note those numbers are just a preview since this CL doesn't have a
corresponding change in common.gypi to set toolkit-views=1 by default on
Mac.

BUG=390755
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286355

[Andre, 2014-07-18 20:08:57]

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:1825:
'chrome_browser_ui_task_manager_non_mac_sources': [
I think TaskManagerView is now ready for MacViews.
Can we make task_manager_view.cc part of chrome_browser_ui_views_sources?
(conditional on enable_task_manager=1)
We may need to add ifdef to avoid duplicate ShowTaskManager.

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:1830: 'browser/ui/cocoa/task_manager_mac.mm',
These 2 files are also part of chrome_browser_ui_non_ios_sources.
Delete them from there?
That may break the TaskManagerMac code in AppControllerMac if
enable_task_manager is 0. We can change that code to call
chrome::OpenTaskManager instead.

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:2653: 'sources': [
'<@(chrome_browser_ui_task_manager_sources' ],
Accidentally deleted the closing parenthesis?

[tapted, 2014-07-23 03:20:32]

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:1830: 'browser/ui/cocoa/task_manager_mac.mm',
On 2014/07/18 20:08:57, Andre wrote:
> These 2 files are also part of chrome_browser_ui_non_ios_sources.
> Delete them from there?
> That may break the TaskManagerMac code in AppControllerMac if
> enable_task_manager is 0. We can change that code to call
> chrome::OpenTaskManager instead.

I'll think up some way to consolidate these.. For 3 files, task manager sure
does appear a lot. The gn build rules have much neater filtering - I might be
able to mimic that.

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:2653: 'sources': [
'<@(chrome_browser_ui_task_manager_sources' ],
On 2014/07/18 20:08:57, Andre wrote:
> Accidentally deleted the closing parenthesis?

Done - good catch (shakes fist@ gyp). It's possible the gyp-parser didn't even
notice this :/

[tapted, 2014-07-23 03:20:39]

Not for review yet (although it shouldn't change too much). But I have some
really promising sizes stats - this seems to only regress sizes in a
local/official build by 0.14%: 78,360kB to 78,252kB.

Now to get all those test targets compiling...

[tapted, 2014-07-29 08:04:10]

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/375843002/diff/180001/chrome/chrome_browser_u...
chrome/chrome_browser_ui.gypi:1830: 'browser/ui/cocoa/task_manager_mac.mm',
On 2014/07/23 03:20:31, tapted wrote:
> On 2014/07/18 20:08:57, Andre wrote:
> > These 2 files are also part of chrome_browser_ui_non_ios_sources.
> > Delete them from there?
> > That may break the TaskManagerMac code in AppControllerMac if
> > enable_task_manager is 0. We can change that code to call
> > chrome::OpenTaskManager instead.
> 
> I'll think up some way to consolidate these.. For 3 files, task manager sure
> does appear a lot. The gn build rules have much neater filtering - I might be
> able to mimic that.

Done (task_manager_mac.* effectively appeared double, so we can just drop one).

[tapted, 2014-07-29 08:29:33]

Hi sky and brettw - please take a look.

This is now just changes to gypi/gn files, and I think it's good to land. It
allows a toolkit-views=1 build on Mac to compile Chrome (and run!). Note it
still runs the Cocoa UI. Patchset 8 (or crrev/408953002 ) has a preview of how a
bit of views UI would be added to the mac build.

I've included a "preview" analysis of sizes regressions in the description.
They're not as bad as I thought the would be. But note this CL should still be a
"no-op" for official builders when it lands since toolkit-views defaults to 0 on
mac.

[sky, 2014-07-29 17:23:12]

LGTM

[brettw, 2014-07-29 20:33:25]

lgtm

[tapted, 2014-07-29 23:09:29]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-29 23:10:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/375843002/240001

[commit-bot: I haz the power, 2014-07-30 00:10:45]

Change committed as 286355