Move Copy method from DrawQuad to RenderPass

Move Copy method from DrawQuad to RenderPass

In transition to let RenderPass take responsibility to allocate
DrawQuads, Copy method from DQ is moved to RP.

In drawquad_unittest, no RenderPass is present, thus it takes advantage
of default copy constructor.

Follow 368403003.

BUG=344962
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282640

[jamesr, 2014-07-09 22:18:18]

(aside: the TEST= line is supposed to be instructions for manual QA steps only.
If a change is covered by automated tests, omit that field)

[weiliangc, 2014-07-09 22:21:51]

On 2014/07/09 22:18:18, jamesr wrote:
> (aside: the TEST= line is supposed to be instructions for manual QA steps
only.
> If a change is covered by automated tests, omit that field)

Ah, I see. Thanks!

[danakj, 2014-07-09 22:36:17]

https://codereview.chromium.org/380893004/diff/1/cc/quads/draw_quad_unittest.cc
File cc/quads/draw_quad_unittest.cc (right):

https://codereview.chromium.org/380893004/diff/1/cc/quads/draw_quad_unittest....
cc/quads/draw_quad_unittest.cc:108: scoped_ptr<Type> copy_new(new
Type(*quad_new));                           \
This was meant to test the Copy() method on DrawQuad to ensure everything is
copied. We should be testing the RenderPass copy method instead. If you need to
rewrite this some feel free..

[weiliangc, 2014-07-10 19:29:21]

On 2014/07/09 22:36:17, danakj wrote:
>
https://codereview.chromium.org/380893004/diff/1/cc/quads/draw_quad_unittest.cc
> File cc/quads/draw_quad_unittest.cc (right):
> 
>
https://codereview.chromium.org/380893004/diff/1/cc/quads/draw_quad_unittest....
> cc/quads/draw_quad_unittest.cc:108: scoped_ptr<Type> copy_new(new
> Type(*quad_new));                           \
> This was meant to test the Copy() method on DrawQuad to ensure everything is
> copied. We should be testing the RenderPass copy method instead. If you need
to
> rewrite this some feel free..

Added RenderPass to DQ_unittests, now actually tests the Copy function. :)

[danakj, 2014-07-10 19:53:25]

https://codereview.chromium.org/380893004/diff/20001/cc/quads/draw_quad_unitt...
File cc/quads/draw_quad_unittest.cc (right):

https://codereview.chromium.org/380893004/diff/20001/cc/quads/draw_quad_unitt...
cc/quads/draw_quad_unittest.cc:121: #define SETUP_AND_COPY_QUAD_NEW_1(Type,
quad, a)                         \
let's rename this to say RENDER_PASS or RP or something instead of _1 since the
code is explcitly for that now

https://codereview.chromium.org/380893004/diff/20001/cc/quads/draw_quad_unitt...
cc/quads/draw_quad_unittest.cc:438: scoped_ptr<RenderPass> render_pass =
RenderPass::Create();
can we move this into the CREATE_SHARED_STATE() macro? would that work?

https://codereview.chromium.org/380893004/diff/20001/cc/quads/render_pass.cc
File cc/quads/render_pass.cc (right):

https://codereview.chromium.org/380893004/diff/20001/cc/quads/render_pass.cc#...
cc/quads/render_pass.cc:111:
copy_pass->CopyFromAndAppendTypedDrawQuad<RenderPassDrawQuad>(
Why not copy_pass->CopyFromAndAppendRenderPassDrawQuad

[weiliangc, 2014-07-11 15:59:12]

https://codereview.chromium.org/380893004/diff/20001/cc/quads/draw_quad_unitt...
File cc/quads/draw_quad_unittest.cc (right):

https://codereview.chromium.org/380893004/diff/20001/cc/quads/draw_quad_unitt...
cc/quads/draw_quad_unittest.cc:121: #define SETUP_AND_COPY_QUAD_NEW_1(Type,
quad, a)                         \
On 2014/07/10 19:53:25, danakj wrote:
> let's rename this to say RENDER_PASS or RP or something instead of _1 since
the
> code is explcitly for that now

Done.

https://codereview.chromium.org/380893004/diff/20001/cc/quads/draw_quad_unitt...
cc/quads/draw_quad_unittest.cc:438: scoped_ptr<RenderPass> render_pass =
RenderPass::Create();
On 2014/07/10 19:53:25, danakj wrote:
> can we move this into the CREATE_SHARED_STATE() macro? would that work?

Done.

https://codereview.chromium.org/380893004/diff/20001/cc/quads/render_pass.cc
File cc/quads/render_pass.cc (right):

https://codereview.chromium.org/380893004/diff/20001/cc/quads/render_pass.cc#...
cc/quads/render_pass.cc:111:
copy_pass->CopyFromAndAppendTypedDrawQuad<RenderPassDrawQuad>(
On 2014/07/10 19:53:25, danakj wrote:
> Why not copy_pass->CopyFromAndAppendRenderPassDrawQuad

Done.

[danakj, 2014-07-11 16:13:31]

LGTM

[danakj, 2014-07-11 16:13:34]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-07-11 16:14:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/380893004/60001

[commit-bot: I haz the power, 2014-07-11 17:24:57]

Change committed as 282640