Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 380863002: Cleanup: Fix some misc issues in Linux media galleries MTP code. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Project:
chromium
Visibility:
Public.

Description

Cleanup: Fix some misc issues in Linux media galleries MTP code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282252

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h View 1 chunk +1 line, -1 line 2 comments Download
M chrome/browser/media_galleries/linux/mtp_device_object_enumerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-09 19:08:28 UTC) #1
tommycli
https://codereview.chromium.org/380863002/diff/1/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h File chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h (left): https://codereview.chromium.org/380863002/diff/1/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h#oldcode28 chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h:28: bool GetEntryId(uint32_t* entry_id) const; base/basictypes.h says to use uint32_t
6 years, 5 months ago (2014-07-09 19:14:42 UTC) #2
tommycli
lgtm otherwise
6 years, 5 months ago (2014-07-09 19:15:56 UTC) #3
Lei Zhang
https://codereview.chromium.org/380863002/diff/1/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h File chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h (left): https://codereview.chromium.org/380863002/diff/1/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h#oldcode28 chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h:28: bool GetEntryId(uint32_t* entry_id) const; On 2014/07/09 19:14:42, tommycli wrote: ...
6 years, 5 months ago (2014-07-09 19:21:40 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-09 19:21:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/380863002/1
6 years, 5 months ago (2014-07-09 19:24:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 23:38:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 02:12:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/47470)
6 years, 5 months ago (2014-07-10 02:12:05 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-10 02:16:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/380863002/1
6 years, 5 months ago (2014-07-10 02:18:07 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 04:29:48 UTC) #12
Message was sent while issue was closed. 
Change committed as 282252

Powered by Google App Engine
This is Rietveld 408576698