chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h - Issue 380863002: Cleanup: Fix some misc issues in Linux media galleries MTP code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h

Issue 380863002: Cleanup: Fix some misc issues in Linux media galleries MTP code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc ('k') | chrome/browser/media_galleries/linux/mtp_device_object_enumerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h

diff --git a/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h b/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h

index 7f8b611f523a04a0ee2e8dc07e76cbb19198eee5..f6ea42f0f63b44d38421a51cdc78949c99f44545 100644

--- a/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h

+++ b/chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h

@@ -25,7 +25,7 @@ class MTPDeviceObjectEnumerator {

// If the current file entry is valid, returns true and fills in |entry_id|

// with the entry identifier else returns false and |entry_id| is not set.

- bool GetEntryId(uint32_t* entry_id) const;

tommycli 2014/07/09 19:14:42 base/basictypes.h says to use uint32_t

Lei Zhang 2014/07/09 19:21:40 That happened 6 months ago and all this code was w

+ bool GetEntryId(uint32* entry_id) const;

private:

// Returns true if the enumerator has more entries to traverse, false