components/password_manager/core/browser/password_manager.h - Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_generation_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | components/password_manager/core/common/password_manager_pref_names.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.h

diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h

index 45a7f93fa47ac6c34420636852c080608e5f69fc..9ffb6b6fee13e66645859d35e11ef0c3d8244132 100644

--- a/components/password_manager/core/browser/password_manager.h

+++ b/components/password_manager/core/browser/password_manager.h

@@ -178,9 +178,9 @@ class PasswordManager : public LoginModel {

// The platform-level driver. Must outlive this class.

PasswordManagerDriver* const driver_;

- // Set to false to disable the password manager (will no longer ask if you

+ // Set to false to disable password saving (will no longer ask if you

// want to save passwords but will continue to fill passwords).

- BooleanPrefMember password_manager_enabled_;

+ BooleanPrefMember saving_password_enabled_;

vabr (Chromium) 2014/07/10 08:36:54 nit: saving_passwords_enabled_ (plural, as this ap

Nikhil 2014/07/10 09:56:35 Done.

// Observers to be notified of LoginModel events. This is mutable to allow

// notification in const member functions.