Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: components/password_manager/core/browser/password_manager.h

Issue 380713003: PasswordManager - update "password_manager_enabled_" pref name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 // Scoped in case PasswordManager gets deleted (e.g tab closes) between the 171 // Scoped in case PasswordManager gets deleted (e.g tab closes) between the
172 // time a user submits a login form and gets to the next page. 172 // time a user submits a login form and gets to the next page.
173 scoped_ptr<PasswordFormManager> provisional_save_manager_; 173 scoped_ptr<PasswordFormManager> provisional_save_manager_;
174 174
175 // The embedder-level client. Must outlive this class. 175 // The embedder-level client. Must outlive this class.
176 PasswordManagerClient* const client_; 176 PasswordManagerClient* const client_;
177 177
178 // The platform-level driver. Must outlive this class. 178 // The platform-level driver. Must outlive this class.
179 PasswordManagerDriver* const driver_; 179 PasswordManagerDriver* const driver_;
180 180
181 // Set to false to disable the password manager (will no longer ask if you 181 // Set to false to disable password saving (will no longer ask if you
182 // want to save passwords but will continue to fill passwords). 182 // want to save passwords but will continue to fill passwords).
183 BooleanPrefMember password_manager_enabled_; 183 BooleanPrefMember saving_password_enabled_;
vabr (Chromium) 2014/07/10 08:36:54 nit: saving_passwords_enabled_ (plural, as this ap
Nikhil 2014/07/10 09:56:35 Done.
184 184
185 // Observers to be notified of LoginModel events. This is mutable to allow 185 // Observers to be notified of LoginModel events. This is mutable to allow
186 // notification in const member functions. 186 // notification in const member functions.
187 mutable ObserverList<LoginModelObserver> observers_; 187 mutable ObserverList<LoginModelObserver> observers_;
188 188
189 // Callbacks to be notified when a password form has been submitted. 189 // Callbacks to be notified when a password form has been submitted.
190 std::vector<PasswordSubmittedCallback> submission_callbacks_; 190 std::vector<PasswordSubmittedCallback> submission_callbacks_;
191 191
192 // Records all visible forms seen during a page load, in all frames of the 192 // Records all visible forms seen during a page load, in all frames of the
193 // page. When the page stops loading, the password manager checks if one of 193 // page. When the page stops loading, the password manager checks if one of
194 // the recorded forms matches the login form from the previous page 194 // the recorded forms matches the login form from the previous page
195 // (to see if the login was a failure), and clears the vector. 195 // (to see if the login was a failure), and clears the vector.
196 std::vector<autofill::PasswordForm> all_visible_forms_; 196 std::vector<autofill::PasswordForm> all_visible_forms_;
197 197
198 DISALLOW_COPY_AND_ASSIGN(PasswordManager); 198 DISALLOW_COPY_AND_ASSIGN(PasswordManager);
199 }; 199 };
200 200
201 } // namespace password_manager 201 } // namespace password_manager
202 202
203 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 203 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698