DescriptionRevert of Remove ability for Release code to call getRefCnt() or getWeakRefCnt(). (https://codereview.chromium.org/378643003/)
Reason for revert:
External unit tests call getRefCnt().
Original issue's description:
> Remove ability for Release code to call getRefCnt() or getWeakRefCnt().
>
> These getRefCnt() methods are not thread safe, so Skia code should not
> be calling them. unique() is fine.
>
> SkDEBUG code (SkASSERTs) can still call getRefCnt() / getWeakRefCnt().
>
> This adds tools/RefCntIs.{h,cpp}, which lets tests make their assertions in
> both debug and release modes.
>
> BUG=skia:2726
>
> Committed: https://skia.googlesource.com/skia/+/4ae94ffce5ecf1b71cb5e295b68bf4ec9e697443
TBR=senorblanco@chromium.org,reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2726
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|