Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: Source/bindings/v8/custom/V8MessageEventCustom.cpp

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8MessageEventCustom.cpp
diff --git a/Source/bindings/v8/custom/V8MessageEventCustom.cpp b/Source/bindings/v8/custom/V8MessageEventCustom.cpp
index 21c4f0e438a703721f63c368238681c3cd44a71c..a44393f521ba873426a41b1e9146dccc4ac09a5f 100644
--- a/Source/bindings/v8/custom/V8MessageEventCustom.cpp
+++ b/Source/bindings/v8/custom/V8MessageEventCustom.cpp
@@ -118,7 +118,7 @@ void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo
if (!isUndefinedOrNull(args[7])) {
portArray = adoptPtr(new MessagePortArray);
- if (!getMessagePortArray(args[7], *portArray, args.GetIsolate()))
+ if (!getMessagePortArray(args[7], 8, *portArray, args.GetIsolate()))
Mike West 2013/10/24 07:08:54 This isn't really your fault, since this call is a
sof 2013/10/24 21:16:41 good idea, done. I filed http://code.google.com/p
return;
}
event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, originArg, lastEventIdArg, sourceArg, portArray.release());

Powered by Google App Engine
This is Rietveld 408576698