Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/bindings/v8/V8Utilities.h

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8Utilities.h
diff --git a/Source/bindings/v8/V8Utilities.h b/Source/bindings/v8/V8Utilities.h
index bb1b5896b5d81a80f990c2f52897d86fc55de9e9..23cefd84afee2034536c6ec66ee8895529ffdf6e 100644
--- a/Source/bindings/v8/V8Utilities.h
+++ b/Source/bindings/v8/V8Utilities.h
@@ -63,7 +63,8 @@ namespace WebCore {
// then being responsible for generating a TypeError having a message that fits the context.
// Returns true if the array was filled, or false if the passed value was not of an appropriate type.
bool extractTransferables(v8::Local<v8::Value>, MessagePortArray&, ArrayBufferArray&, bool& notASequence, v8::Isolate*);
- bool getMessagePortArray(v8::Local<v8::Value>, MessagePortArray&, v8::Isolate*);
+ bool getMessagePortArray(v8::Local<v8::Value>, const String&, MessagePortArray&, v8::Isolate*);
Mike West 2013/10/24 07:08:54 Please add a name here. 'String&' isn't descriptiv
+ bool getMessagePortArray(v8::Local<v8::Value>, int, MessagePortArray&, v8::Isolate*);
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698