Source/bindings/v8/ExceptionMessages.h - Issue 38063003: Improve TypeError messages from failed array conversions.

Side by Side Diff: Source/bindings/v8/ExceptionMessages.h

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 25 matching lines...) Expand all Loading...
36 namespace WebCore {	36 namespace WebCore {

37	37

38 class ExceptionMessages {	38 class ExceptionMessages {

39 public:	39 public:

40 static String failedToConstruct(const String& type, const String& detail = S tring());	40 static String failedToConstruct(const String& type, const String& detail = S tring());

41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());	41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());

42 static String failedToGet(const String& property, const String& type, const String& detail);	42 static String failedToGet(const String& property, const String& type, const String& detail);

43 static String failedToSet(const String& property, const String& type, const String& detail);	43 static String failedToSet(const String& property, const String& type, const String& detail);

44 static String failedToDelete(const String& property, const String& type, con st String& detail);	44 static String failedToDelete(const String& property, const String& type, con st String& detail);

45	45

46 static String notASequenceType(const String& argument);	46 static String notASequenceType(int argumentIndex);
	Mike West 2013/10/24 07:08:54 `notASequenceType(2)` isn't particularly readable. `notASequenceType(2)` isn't particularly readable. Perhaps rename this to 'notASequenceTypeAtIndex'? I'm a bit worried that we're otherwise sprinkling magic numbers through the code that aren't particularly clear. sof 2013/10/24 21:16:41 Agree with the concern; tidied up the use of const Show quoted text On 2013/10/24 07:08:54, Mike West wrote: > `notASequenceType(2)` isn't particularly readable. Perhaps rename this to > 'notASequenceTypeAtIndex'? I'm a bit worried that we're otherwise sprinkling > magic numbers through the code that aren't particularly clear. Agree with the concern; tidied up the use of constants at the call sites + tried to improve naming & purpose of this helper.
	47 static String notASequenceType(const String& argument, const String& argumen tKind = String());
	Mike West 2013/10/24 07:08:54 Is the optionality of the second argument actually Is the optionality of the second argument actually used? It looks like you're calling this with 'property' everywhere. If so, I'd suggest just renaming it to 'notASequenceTypeInProperty' or something similar, and dropping the second argument.
47 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);	48 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);

48 };	49 };

49	50

50 } // namespace WebCore	51 } // namespace WebCore

51	52

52 #endif // ExceptionMessages_h	53 #endif // ExceptionMessages_h

OLD	NEW