Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: Source/bindings/v8/ExceptionMessages.h

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ExceptionMessages.h
diff --git a/Source/bindings/v8/ExceptionMessages.h b/Source/bindings/v8/ExceptionMessages.h
index 440b00920416c1a290bf0fc3c81a25ce94921c53..6bd37d02784c63558a591a38350529916164f700 100644
--- a/Source/bindings/v8/ExceptionMessages.h
+++ b/Source/bindings/v8/ExceptionMessages.h
@@ -43,7 +43,8 @@ public:
static String failedToSet(const String& property, const String& type, const String& detail);
static String failedToDelete(const String& property, const String& type, const String& detail);
- static String notASequenceType(const String& argument);
+ static String notASequenceType(int argumentIndex);
Mike West 2013/10/24 07:08:54 `notASequenceType(2)` isn't particularly readable.
sof 2013/10/24 21:16:41 Agree with the concern; tidied up the use of const
+ static String notASequenceType(const String& argument, const String& argumentKind = String());
Mike West 2013/10/24 07:08:54 Is the optionality of the second argument actually
static String notEnoughArguments(unsigned expected, unsigned providedleastNumMandatoryParams);
};

Powered by Google App Engine
This is Rietveld 408576698