Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 380623002: Revert of Instrumented libraries: turn off leak detection when building with ASan. (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Instrumented libraries: turn off leak detection when building with ASan. (https://codereview.chromium.org/376733006/) Reason for revert: http://build.chromium.org/p/chromium.lkgr/builders/MSAN%20Release%20%28no%20origins%29/builds/41/steps/compile/logs/stdio FAILED: cd ../../third_party/instrumented_libraries; ../../third_party/instrumented_libraries/download_build_install.py "--product-directory=../../out/Release" "--package=libappindicator1" "--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libappindicator1.gen" "--sanitizer-type=msan" "--extra-configure-flags=--disable-introspection" "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\"" "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--patch=" "--run-before-build=" "--cc=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang" "--cxx=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang++" "--jobs=1" "--build-method=destdir" "--sanitizer-blacklist=../../out/Release/../../tools/msan/blacklist.txt" Traceback (most recent call last): File "../../third_party/instrumented_libraries/download_build_install.py", line 366, in <module> main() File "../../third_party/instrumented_libraries/download_build_install.py", line 362, in main download_build_install(parsed_arguments) File "../../third_party/instrumented_libraries/download_build_install.py", line 262, in download_build_install environment = build_environment(parsed_arguments, install_prefix) File "../../third_party/instrumented_libraries/download_build_install.py", line 232, in build_environment product_directory, Original issue's description: > Instrumented libraries: turn off leak detection when building with ASan. > > Fixes a build failure. I also did some refactoring. > > BUG=313751 > TBR=glider@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804 TBR=glider@chromium.org,earthdok@chromium.org NOTREECHECKS=true NOTRY=true BUG=313751 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 4 chunks +13 lines, -25 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
horo
Created Revert of Instrumented libraries: turn off leak detection when building with ASan.
6 years, 5 months ago (2014-07-09 05:36:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/380623002/1
6 years, 5 months ago (2014-07-09 05:38:00 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 06:20:36 UTC) #3
Message was sent while issue was closed.
Change committed as 281977

Powered by Google App Engine
This is Rietveld 408576698