Re-land: Instrumented libraries: turn off leak detection when building with ASan.

Instrumented libraries: turn off leak detection when building with ASan.

Fixes a build failure. I also did some refactoring.
This is a re-land that fixes a build error.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282021

[earthdok, 2014-07-08 17:12:08]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2014-07-08 17:13:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/earthdok@chromium.org/376733006/1

[commit-bot: I haz the power, 2014-07-08 20:05:24]

Change committed as 281804

[horo, 2014-07-09 05:36:14]

A revert of this CL has been created in
https://codereview.chromium.org/380623002/ by horo@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.lkgr/builders/MSAN%20Release%20%28no%20o...

FAILED: cd ../../third_party/instrumented_libraries;
../../third_party/instrumented_libraries/download_build_install.py
"--product-directory=../../out/Release" "--package=libappindicator1"
"--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libappindicator1.gen"
"--sanitizer-type=msan" "--extra-configure-flags=--disable-introspection"
"--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE
\"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\""
"--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--patch="
"--run-before-build=" "--cc=/mnt/data/b/build/goma/gomacc
/mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang"
"--cxx=/mnt/data/b/build/goma/gomacc
/mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang++"
"--jobs=1" "--build-method=destdir"
"--sanitizer-blacklist=../../out/Release/../../tools/msan/blacklist.txt"
Traceback (most recent call last):
  File "../../third_party/instrumented_libraries/download_build_install.py",
line 366, in <module>
    main()
  File "../../third_party/instrumented_libraries/download_build_install.py",
line 362, in main
    download_build_install(parsed_arguments)
  File "../../third_party/instrumented_libraries/download_build_install.py",
line 262, in download_build_install
    environment = build_environment(parsed_arguments, install_prefix)
  File "../../third_party/instrumented_libraries/download_build_install.py",
line 232, in build_environment
    product_directory,

.

[earthdok, 2014-07-09 13:14:32]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2014-07-09 13:15:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/earthdok@chromium.org/376733006/20001

[commit-bot: I haz the power, 2014-07-09 13:16:25]

Change committed as 282021