Issue 380483002: Add //testing/perf and fix up output file location in yasm_assemble.gni.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380483002: Add //testing/perf and fix up output file location in yasm_assemble.gni. (Closed)

Created:
6 years, 5 months ago by awong

Modified:
6 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add BUILD.gn for //testing/perf. All hail GN. oRZ BUG=none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282443

Patch Set 2 : just 1 file now #

Patch Set 3 : w/o the copy #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	A	testing/perf/BUILD.gn	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

https://codereview.chromium.org/380483002/diff/1/third_party/yasm/yasm_assemble.gni File third_party/yasm/yasm_assemble.gni (right): https://codereview.chromium.org/380483002/diff/1/third_party/yasm/yasm_assemble.gni#newcode164 third_party/yasm/yasm_assemble.gni:164: outputs = [ "$target_gen_dir/{{source_name_part}}.o" ] Why change this? The ...

6 years, 5 months ago (2014-07-08 21:11:48 UTC) #2

awong

6 years, 5 months ago (2014-07-10 22:47:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r282443 (presubmit successful).