Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: third_party/yasm/yasm_assemble.gni

Issue 380483002: Add //testing/perf and fix up output file location in yasm_assemble.gni. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « testing/perf/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This provides the yasm_assemble() template which uses YASM to assemble 5 # This provides the yasm_assemble() template which uses YASM to assemble
6 # assembly files. 6 # assembly files.
7 # 7 #
8 # Files to be assembled with YASM should have an extension of .asm. 8 # Files to be assembled with YASM should have an extension of .asm.
9 # 9 #
10 # Parameters 10 # Parameters
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 } 154 }
155 } 155 }
156 156
157 # Output file. 157 # Output file.
158 # 158 #
159 # TODO(brettw) it might be nice if there was a source expansion for the 159 # TODO(brettw) it might be nice if there was a source expansion for the
160 # path of the source file relative to the source root. Then we could 160 # path of the source file relative to the source root. Then we could
161 # exactly duplicate the naming and location of object files from the 161 # exactly duplicate the naming and location of object files from the
162 # native build, which would be: 162 # native build, which would be:
163 # "$root_out_dir/${target_name}.{{source_dir_part}}.$asm_obj_extension" 163 # "$root_out_dir/${target_name}.{{source_dir_part}}.$asm_obj_extension"
164 outputs = [ "$target_out_dir/{{source_name_part}}.o" ] 164 outputs = [ "$target_gen_dir/{{source_name_part}}.o" ]
brettw 2014/07/08 21:11:48 Why change this? The out dir is where the normal .
165 args += [ 165 args += [
166 "-o", rebase_path(outputs[0], root_build_dir), 166 "-o", rebase_path(outputs[0], root_build_dir),
167 "{{source}}" 167 "{{source}}"
168 ] 168 ]
169 169
170 # The wrapper script run_yasm will write the depfile to the same name as 170 # The wrapper script run_yasm will write the depfile to the same name as
171 # the output but with .d appended (like gcc will). 171 # the output but with .d appended (like gcc will).
172 depfile = outputs[0] + ".d" 172 depfile = outputs[0] + ".d"
173 } 173 }
174 174
175 # Gather the .o files into a linkable thing. This doesn't actually link 175 # Gather the .o files into a linkable thing. This doesn't actually link
176 # anything (a source set just compiles files to link later), but will pass 176 # anything (a source set just compiles files to link later), but will pass
177 # the object files generated by the action up the dependency chain. 177 # the object files generated by the action up the dependency chain.
178 source_set(source_set_name) { 178 source_set(source_set_name) {
179 if (defined(invoker.visibility)) { 179 if (defined(invoker.visibility)) {
180 visibility = invoker.visibility 180 visibility = invoker.visibility
181 } 181 }
182 182
183 sources = get_target_outputs(":$action_name") 183 sources = get_target_outputs(":$action_name")
184 } 184 }
185 } 185 }
OLDNEW
« no previous file with comments | « testing/perf/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698