Issue 380473002: Missing volatile in AnnotateBenignRaceSized declaration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380473002: Missing volatile in AnnotateBenignRaceSized declaration. (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Missing volatile in AnnotateBenignRaceSized declaration. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f7a180b

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -45 lines)			Patch
M	gyp/common_conditions.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkDynamicAnnotations.h	View	1	2 chunks	+40 lines, -3 lines	0 comments	Download
M	include/core/SkMatrix.h	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	include/core/SkPathRef.h	View	1	4 chunks	+9 lines, -7 lines	0 comments	Download
M	include/core/SkPixelRef.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/core/SkPathRef.cpp	View	1	3 chunks	+10 lines, -12 lines	0 comments	Download
M	tools/tsan.supp	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download

Total messages: 2 (0 generated)

mtklein

6 years, 5 months ago (2014-07-08 21:04:02 UTC) #2

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/379623004/ by mtklein@google.com.

The reason for reverting is: sdf.