Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: tools/tsan.supp

Issue 380473002: Missing volatile in AnnotateBenignRaceSized declaration. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: check unique define Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkPathRef.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Suppressions for Thread Sanitizer 1 # Suppressions for Thread Sanitizer
2 # 2 #
3 # CAREFUL! Comments must go on their own line or your suppressions will silentl y fail. 3 # CAREFUL! Comments must go on their own line or your suppressions will silentl y fail.
4 4
5 # WebP races (harmlessly) choosing function pointers for SIMD versions of some o f its functions. 5 # WebP races (harmlessly) choosing function pointers for SIMD versions of some o f its functions.
6 race:third_party/externals/libwebp 6 race:third_party/externals/libwebp
7 7
8 # Poppler races on startup. 8 # Poppler races on startup.
9 race:libpoppler.so 9 race:libpoppler.so
10 # LCMS is used by poppler, and also races. 10 # LCMS is used by poppler, and also races.
11 race:liblcms2.so 11 race:liblcms2.so
12 12
13 # skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers. 13 # skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
14 # Having trouble getting this suppression to match. 14 # Having trouble getting this suppression to match.
15 # We've tried: race:swrast_dri.so 15 # We've tried: race:swrast_dri.so
16 # race:SkGLContextHelper::init 16 # race:SkGLContextHelper::init
17 # Maybe because it's diagnosed as a use-after-free, not as a race? 17 # Maybe because it's diagnosed as a use-after-free, not as a race?
18 race:SkGLContextHelper 18 race:SkGLContextHelper
19 19
20 # Threadsafe, should be ported to SkLazyPtr. 20 # Threadsafe, should be ported to SkLazyPtr.
21 race:SkFontHost_FreeType 21 race:SkFontHost_FreeType
22 race:is_lcd_supported 22 race:is_lcd_supported
23 23
24 # Not threadsafe, should be fixed. 24 # Not threadsafe, should be fixed.
25 race:RefFCI 25 race:RefFCI
26 race:SkString 26 race:SkString
27 race:SkPDF 27 race:SkPDF
28
29 # These race benignly as used by DMQuiltTask: skia:2725.
30 # Suppress while I look for a more focused way to silence this.
31 race:SkPixelRef::callGenIDChangeListeners
32 race:SkPixelRef::needsNewGenID
33
34 # SkPathRef caches its bounding box the first time it's needed.
35 # This will be fixed naturally once we create (from a single thread) a
36 # bounding-box hierarchy for SkRecord-based SkPictures; all bounds will come pre -cached.
37 # So just shut this up for now.
38 race:SkPathRef::computeBounds
39
40 # SkMatrix caches a type mask. If we race on this, we'll just calculate the sam e thing a few times.
41 race:SkMatrix::getType
42 race:SkMatrix::rectStaysRect
43 race:SkMatrix::getPerspectiveTypeMaskOnly
44
45 # TODO: some sort of SkRacy<T> to handle cases like SkMatrix, SkPathRef, SkPixel Ref above?
OLDNEW
« no previous file with comments | « src/core/SkPathRef.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698