Issue 380303004: Revert 282424 "Remove media::AudioRendererImpl::now_cb_ and clea..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380303004: Revert 282424 "Remove media::AudioRendererImpl::now_cb_ and clea..." (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)

Modified:
6 years, 5 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 282424 "Remove media::AudioRendererImpl::now_cb_ and clea..." MSVC evaluates functions in a different order, causing test failures. > Remove media::AudioRendererImpl::now_cb_ and clean up tests. > > It's no longer needed as of r282376. > > BUG=370634 > R=rileya@chromium.org > > Review URL: https://codereview.chromium.org/380893002 TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282436

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -57 lines)			Patch
M	trunk/src/media/filters/audio_renderer_impl.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	trunk/src/media/filters/audio_renderer_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/media/filters/audio_renderer_impl_unittest.cc	View	24 chunks	+151 lines, -57 lines	0 comments	Download

Total messages: 2 (0 generated)

scherkus (not reviewing)

6 years, 5 months ago (2014-07-10 21:44:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r282436.