Use base::TickClock in media::AudioRendererImpl instead of a callback.

Remove media::AudioRendererImpl::now_cb_ and clean up tests.

It's no longer needed as of r282376.

BUG=370634
R=rileya@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282424

[scherkus (not reviewing), 2014-07-09 20:23:45]

rileya: care to review this one?

[rileya (GONE FROM CHROMIUM), 2014-07-10 18:52:36]

lgtm % nit

https://codereview.chromium.org/380893002/diff/1/media/filters/audio_renderer...
File media/filters/audio_renderer_impl_unittest.cc (right):

https://codereview.chromium.org/380893002/diff/1/media/filters/audio_renderer...
media/filters/audio_renderer_impl_unittest.cc:418: void AdvanceTime(TimeDelta
time) {
Tiny nit: naming parameters after globals usually makes me nervous (<ctime> is
included, so 'time' in global scope is a fn ptr), in case the parameter was
renamed and the use below wasn't updated or something like that.

Highly unlikely in this case, and any sane compiler would complain about passing
a function pointer for a TimeDelta... but still, worth a mention.

[scherkus (not reviewing), 2014-07-10 19:45:53]

rileya: can you take another look? it turns out we're better off removing the
whole thing for now

https://codereview.chromium.org/380893002/diff/1/media/filters/audio_renderer...
File media/filters/audio_renderer_impl_unittest.cc (right):

https://codereview.chromium.org/380893002/diff/1/media/filters/audio_renderer...
media/filters/audio_renderer_impl_unittest.cc:418: void AdvanceTime(TimeDelta
time) {
On 2014/07/10 18:52:36, rileya wrote:
> Tiny nit: naming parameters after globals usually makes me nervous (<ctime> is
> included, so 'time' in global scope is a fn ptr), in case the parameter was
> renamed and the use below wasn't updated or something like that.
> 
> Highly unlikely in this case, and any sane compiler would complain about
passing
> a function pointer for a TimeDelta... but still, worth a mention.

Thanks for the heads up. It should be safe to rely on the compiler doing the
right thing.

FWIW there's lots of |time| variables out there:
https://code.google.com/p/chromium/codesearch#search/&q=TimeDelta%5C%20time%5...

[rileya (GONE FROM CHROMIUM), 2014-07-10 20:33:05]

Judging by the red tries, and the lack of some removed |now_cb_|s in PS2's diff
for audio_renderer_impl.cc (though I don't see them when expand-all-ing), it
looks like something may have merged/rebased incorrectly?

[scherkus (not reviewing), 2014-07-10 20:35:02]

On 2014/07/10 20:33:05, rileya wrote:
> Judging by the red tries, and the lack of some removed |now_cb_|s in PS2's
diff
> for audio_renderer_impl.cc (though I don't see them when expand-all-ing), it
> looks like something may have merged/rebased incorrectly?

the red bots were a try run that synced to r282042, which doesn't include
r282376

the green bots were forced to run a try join @ r282376 (i.e., git cl try
-r282376)

[rileya (GONE FROM CHROMIUM), 2014-07-10 20:37:03]

On 2014/07/10 20:35:02, scherkus wrote:
> On 2014/07/10 20:33:05, rileya wrote:
> > Judging by the red tries, and the lack of some removed |now_cb_|s in PS2's
> diff
> > for audio_renderer_impl.cc (though I don't see them when expand-all-ing), it
> > looks like something may have merged/rebased incorrectly?
> 
> the red bots were a try run that synced to r282042, which doesn't include
> r282376
> 
> the green bots were forced to run a try join @ r282376 (i.e., git cl try
> -r282376)

gotcha, lgtm

[scherkus (not reviewing), 2014-07-10 20:48:15]

Committed patchset #2 manually as r282424 (presubmit successful).

[eseidel, 2014-07-10 23:42:54]

Looks liek this broke:
AudioRendererImplTest.PendingRead_Stop
AudioRendererImplTest.PendingRead_Flush
AudioRendererImplTest.Underflow_CapacityResetsAfterFlush
AudioRendererImplTest.Underflow
AudioRendererImplTest.EndOfStream
AudioRendererImplTest.ConfigChangeDrainsConverter
AudioRendererImplTest.StartRendering
AudioRendererImplTest.Underflow_Flush
AudioRendererImplTest.PendingFlush_Stop

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/bu...

[scherkus (not reviewing), 2014-07-10 23:43:43]

On 2014/07/10 23:42:54, eseidel wrote:
> Looks liek this broke:
> AudioRendererImplTest.PendingRead_Stop
> AudioRendererImplTest.PendingRead_Flush
> AudioRendererImplTest.Underflow_CapacityResetsAfterFlush
> AudioRendererImplTest.Underflow
> AudioRendererImplTest.EndOfStream
> AudioRendererImplTest.ConfigChangeDrainsConverter
> AudioRendererImplTest.StartRendering
> AudioRendererImplTest.Underflow_Flush
> AudioRendererImplTest.PendingFlush_Stop
> 
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/bu...

was already reverted
http://src.chromium.org/viewvc/chrome?revision=282436&view=revision