Improve testing for SDCH.

net/filter/mock_filter_context.h

Index: net/filter/mock_filter_context.h
diff --git a/net/filter/mock_filter_context.h b/net/filter/mock_filter_context.h
index 9bb6235a3a9ab161c08880e1421c9b574078d33b..c9ea9c96a592cf5f6338275ee144f08735ae191f 100644
--- a/net/filter/mock_filter_context.h
+++ b/net/filter/mock_filter_context.h
@@ -35,6 +35,9 @@ class MockFilterContext : public FilterContext {
   URLRequestContext* GetModifiableURLRequestContext() const {
     return context_.get();
   }
+  // Make all interfaces that might be unstable after a URLRequests

[mef, 2014/07/23 18:34:30]

nit: nl above.

[Randy Smith (Not in Mondays), 2014/07/29 23:44:21]

Done.

+  // destruction be so.

[jar (doing other things), 2014/07/31 03:24:34]

nit: comment seemed clumsy... or at least I had to read it many times to make
sense of it.  Does the comment really say "make interfaces unstable" because
they would be unstable in real life after a call to URLRequests?    ... or do
you mean to make them invalid after a call to URLRequests?

Suggest perhaps:

// After URLRequests is called, some interfaces may become unstable. This method
is used to signal that state, so we can tag calls to those interfaces as coding
errors.

[Randy Smith (Not in Mondays), 2014/08/11 20:33:25]

s/URLRequests/URLRequest's destructor/.

I mean to make them invalid after a call to the destructor because they may be
so in real life.
Done.

+  void NukeUnstableInterfaces();
 
   virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
 
@@ -77,6 +80,7 @@ class MockFilterContext : public FilterContext {
   bool is_cached_content_;
   bool is_download_;
   bool is_sdch_response_;
+  bool ok_to_call_get_url_;
   int response_code_;
   scoped_ptr<URLRequestContext> context_;