Improve testing for SDCH.

net/filter/mock_filter_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_FILTER_MOCK_FILTER_CONTEXT_H_
 #define NET_FILTER_MOCK_FILTER_CONTEXT_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 17 matching lines @@
   void SetRequestTime(const base::Time time) { request_time_ = time; }
   void SetCached(bool is_cached) { is_cached_content_ = is_cached; }
   void SetDownload(bool is_download) { is_download_ = is_download; }
   void SetResponseCode(int response_code) { response_code_ = response_code; }
   void SetSdchResponse(bool is_sdch_response) {
     is_sdch_response_ = is_sdch_response;
   }
   URLRequestContext* GetModifiableURLRequestContext() const {
     return context_.get();
   }
+  // Make all interfaces that might be unstable after a URLRequests

[mef, 2014/07/23 18:34:30]

nit: nl above.

[Randy Smith (Not in Mondays), 2014/07/29 23:44:21]

Done.

+  // destruction be so.

[jar (doing other things), 2014/07/31 03:24:34]

nit: comment seemed clumsy... or at least I had to read it many times to make
sense of it.  Does the comment really say "make interfaces unstable" because
they would be unstable in real life after a call to URLRequests?    ... or do
you mean to make them invalid after a call to URLRequests?

Suggest perhaps:

// After URLRequests is called, some interfaces may become unstable. This method
is used to signal that state, so we can tag calls to those interfaces as coding
errors.

[Randy Smith (Not in Mondays), 2014/08/11 20:33:25]

s/URLRequests/URLRequest's destructor/.

I mean to make them invalid after a call to the destructor because they may be
so in real life.
Done.

+  void NukeUnstableInterfaces();
 
   virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
 
   // What URL was used to access this data?
   // Return false if gurl is not present.
   virtual bool GetURL(GURL* gurl) const OVERRIDE;
 
   // What Content-Disposition did the server supply for this data?
   // Return false if Content-Disposition was not present.
   virtual bool GetContentDisposition(std::string* disposition) const OVERRIDE;
@@ skipping 22 matching lines @@
 
  private:
   int buffer_size_;
   std::string mime_type_;
   std::string content_disposition_;
   GURL gurl_;
   base::Time request_time_;
   bool is_cached_content_;
   bool is_download_;
   bool is_sdch_response_;
+  bool ok_to_call_get_url_;
   int response_code_;
   scoped_ptr<URLRequestContext> context_;
 
   DISALLOW_COPY_AND_ASSIGN(MockFilterContext);
 };
 
 }  // namespace net
 
 #endif  // NET_FILTER_MOCK_FILTER_CONTEXT_H_