Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 379853002: SkBitmap::Config is deprecated, use SkColorType (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
Reviewers:
malch, f(malita)
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

SkBitmap::Config is deprecated, use SkColorType NOTRY=True BUG=skia:2706 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177768

Patch Set 1 #

Total comments: 1

Patch Set 2 : reset log string to 'config' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/platform/graphics/LoggingCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/LoggingCanvas.cpp View 1 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
reed1
6 years, 5 months ago (2014-07-09 13:50:35 UTC) #1
f(malita)
Looks good, but running it by malch to verify one thing. https://codereview.chromium.org/379853002/diff/1/Source/platform/graphics/LoggingCanvas.cpp File Source/platform/graphics/LoggingCanvas.cpp (right): ...
6 years, 5 months ago (2014-07-09 13:56:51 UTC) #2
reed1
good point - no need to change that in this CL. ptal
6 years, 5 months ago (2014-07-09 14:06:56 UTC) #3
f(malita)
lgtm
6 years, 5 months ago (2014-07-09 14:08:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/379853002/20001
6 years, 5 months ago (2014-07-09 14:08:52 UTC) #5
malch
On 2014/07/09 13:56:51, Florin Malita wrote: > Looks good, but running it by malch to ...
6 years, 5 months ago (2014-07-09 14:10:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-09 15:20:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 16:28:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/15594)
6 years, 5 months ago (2014-07-09 16:28:52 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-09 17:55:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/379853002/20001
6 years, 5 months ago (2014-07-09 17:56:07 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-09 19:01:01 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 20:07:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/15624)
6 years, 5 months ago (2014-07-09 20:07:05 UTC) #14
reed1
On 2014/07/09 20:07:05, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-09 20:25:31 UTC) #15
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-09 20:26:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/379853002/20001
6 years, 5 months ago (2014-07-09 20:27:22 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 21:03:59 UTC) #18
Message was sent while issue was closed. 
Change committed as 177768

Powered by Google App Engine
This is Rietveld 408576698