Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: Source/platform/graphics/LoggingCanvas.cpp

Issue 379853002: SkBitmap::Config is deprecated, use SkColorType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: reset log string to 'config' Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/LoggingCanvas.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/LoggingCanvas.cpp
diff --git a/Source/platform/graphics/LoggingCanvas.cpp b/Source/platform/graphics/LoggingCanvas.cpp
index 511d4b58c0fa4649ca6c7c7ee0cbd044d81ee655..c39c872e47b1aa003429544c4381b6f6bf156010 100644
--- a/Source/platform/graphics/LoggingCanvas.cpp
+++ b/Source/platform/graphics/LoggingCanvas.cpp
@@ -595,15 +595,15 @@ PassRefPtr<JSONObject> LoggingCanvas::objectForSkPath(const SkPath& path)
return pathItem.release();
}
-String LoggingCanvas::configName(SkBitmap::Config config)
-{
- switch (config) {
- case SkBitmap::kNo_Config: return "None";
- case SkBitmap::kA8_Config: return "A8";
- case SkBitmap::kIndex8_Config: return "Index8";
- case SkBitmap::kRGB_565_Config: return "RGB565";
- case SkBitmap::kARGB_4444_Config: return "ARGB4444";
- case SkBitmap::kARGB_8888_Config: return "ARGB8888";
+String LoggingCanvas::colorTypeName(SkColorType colorType)
+{
+ switch (colorType) {
+ case kUnknown_SkColorType: return "None";
+ case kAlpha_8_SkColorType: return "A8";
+ case kIndex_8_SkColorType: return "Index8";
+ case kRGB_565_SkColorType: return "RGB565";
+ case kARGB_4444_SkColorType: return "ARGB4444";
+ case kN32_SkColorType: return "ARGB8888";
default:
ASSERT_NOT_REACHED();
return "?";
@@ -625,7 +625,7 @@ PassRefPtr<JSONObject> LoggingCanvas::objectForSkBitmap(const SkBitmap& bitmap)
RefPtr<JSONObject> bitmapItem = JSONObject::create();
bitmapItem->setNumber("width", bitmap.width());
bitmapItem->setNumber("height", bitmap.height());
- bitmapItem->setString("config", configName(bitmap.config()));
+ bitmapItem->setString("config", colorTypeName(bitmap.colorType()));
bitmapItem->setBoolean("opaque", bitmap.isOpaque());
bitmapItem->setBoolean("immutable", bitmap.isImmutable());
bitmapItem->setBoolean("volatile", bitmap.isVolatile());
« no previous file with comments | « Source/platform/graphics/LoggingCanvas.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698