Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 379603002: Turn off chromium linker on the content shell. (Closed)

Created:
6 years, 5 months ago by simonb (inactive)
Modified:
6 years, 5 months ago
CC:
bulach, chromium-reviews, darin-cc_chromium.org, jam, pasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Turn off chromium linker on the content shell. Revert the content shell portion of: https://codereview.chromium.org/329223002/ This will enable landing of: https://codereview.chromium.org/371943003/ There is an unexplained error when the chromium linker is turned on for the content shell. It manifests (in logcat) as: 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: FATAL EXCEPTION: ChildProcessMain 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: Process: org.chromium.content_shell_apk:sandboxed_process0, PID: 23281 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: java.lang.RuntimeException: Parcel android.os.Parcel@420d90b8: Unmarshalling unknown type code 6881388 at offset 244 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at android.os.Parcel.readValue(Parcel.java:2080) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at android.os.Parcel.readArrayMapInternal(Parcel.java:2314) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at android.os.Bundle.unparcel(Bundle.java:249) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at android.os.Bundle.keySet(Bundle.java:345) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at org.chromium.base.library_loader.Linker.createLibInfoMapFromBundle(Linker.java:1090) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at org.chromium.base.library_loader.Linker.useSharedRelrosLocked(Linker.java:737) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at org.chromium.base.library_loader.Linker.finishLibraryLoad(Linker.java:443) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:179) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at org.chromium.base.library_loader.LibraryLoader.loadNow(LibraryLoader.java:125) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at org.chromium.content.app.ChildProcessService$2.run(ChildProcessService.java:149) 0a3b6: 07-08 13:40:43.925 23281 23295 E AndroidRuntime: at java.lang.Thread.run(Thread.java:841) This does not occur with the chrome shell. The change in https://codereview.chromium.org/371943003/ corrects chromium linker operation and resolves crbug/388356, but to land that requires that we turn off the chromium linker on the content shell first. BUG=388356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
simonb (inactive)
6 years, 5 months ago (2014-07-08 16:05:22 UTC) #1
simonb (inactive)
Jochen, would you mind giving this a quick lgtm. Other stuff is queued behind it. ...
6 years, 5 months ago (2014-07-09 10:27:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-09 11:00:04 UTC) #3
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-09 11:01:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/379603002/1
6 years, 5 months ago (2014-07-09 11:02:15 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 14:15:36 UTC) #6
Message was sent while issue was closed.
Change committed as 282030

Powered by Google App Engine
This is Rietveld 408576698